Skip to content

Bugs with Timed Notebook Gradeable #10440

Description

@bmcutler

Describe the bug
Initially reported by another instructor, I observe the following bugs in timed notebook gradeable on the vagrant machine. "Development" course, "Notebook Time Limit" gradeable (based on the "more_autograding_examples/notebook_time_limit" configuration).

First, I adjusted the due date to be less than 10 minutes from now:
Screenshot 2024-05-15 at 5 00 35 PM

As reported by the instructor, if the student starts very late in the gradeable window, with less than 10 minutes before the due date time, they are incorrectly given a countdown timer of 10 minutes, when they should be given the minimum/smaller of 10 minutes and the time remaining until the due date. Students have mistakenly used most of the 10 minutes, submitted AFTER the deadline, and received a zero and complained it was unfair. If a student starts very late, they will have less than 10 minutes, and that must be made clear on the UI.

Screenshot 2024-05-15 at 3 10 27 PM Screenshot 2024-05-15 at 3 10 31 PM

Edit to clear up bug report in first version of this issue:

A separate confusion happens if there is a clock skew between the server/VM and the client/webbrowser machine. This is hopefully a rare/non-real-world event, but I have encountered it often enough during my own development & testing I think we should fix it.

This can be reproduced by manually setting the VM/server clock to be in the past (e.g., 6 days in the past) relative to the client/webbrowser machine clock. NOTE: This is not just changing the timezone, but rather changing the actual time. Then, the following bugs/confusions happen:

  • The rendering of the timer bar is buggy. It is always dark red. It is always full. I think it's supposed to be a visualization of time remaining. And it extends to the right beyond the end of the bar causing a useless horizontal scroll bar. I see this on Mac Chrome and Mac Safari in light mode. I haven't tested other OS/browsers or dark mode.
Screenshot 2024-05-15 at 2 43 31 PM Screenshot 2024-05-15 at 2 43 36 PM
  • The display indicates that we have many additional days until the deadline. "06 days 03 hours" is roughly the time skew.

  • I would like to see this solved by adding a banner message on this page (on every page?) if the VM/server clock is more than a minute different than the clock on the client/browser. NOTE: This is not just that the timezone is different -- which is a real and normal situation -- but that factoring out the timezone, the clocks are different.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions