[Feature:RainbowGrades] Added Sticky Columns to Gradebook#86
Conversation
dagemcn
left a comment
dagemcn
left a comment
There was a problem hiding this comment.
Functionality looks good, code looked good from my overview, although I'm not super familiar with the libraries used here. However, if I was an instructor, I can see myself scrolling back up and down to see which column I am viewing. I think it could be good to add a sticky row for the title row.
roye2
left a comment
roye2
left a comment
There was a problem hiding this comment.
I took a look at the code and I also tested the functionality and everything looks good.
github-project-automation
Bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
Rkoester47
left a comment
Rkoester47
left a comment
There was a problem hiding this comment.
I tested the changes made on this PR and can confirm that the sticky columns do work correctly. The code changes look reasonable and I could not find issues with functionality.
aconfo
left a comment
aconfo
left a comment
There was a problem hiding this comment.
I tried the functionality and couldn't find any obvious errors or anything I'd recommend changing, looks really good
bmcutler
left a comment
bmcutler
left a comment
There was a problem hiding this comment.
let's not have the numeric ID be sticky.
username + given + last is sufficient
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Work in Progress
in Submitty Development
### Why is this Change Important & Necessary? This is a minor styling change related to [PR#86 in Submitty/RainbowGrades](Submitty/RainbowGrades#86), that prevents the table from overflowing past the sticky columns. ### What is the New Behavior? Before: <img width="1440" height="900" alt="Screenshot_20260406_173230" src="https://github.com/user-attachments/assets/48db20fd-8876-40ea-93d3-2fb0aa453b99" /> After: <img width="1440" height="900" alt="Screenshot_20260406_173456" src="https://github.com/user-attachments/assets/cc9c2c86-09fd-4a70-a2dc-49adeba95ecd" /> ### What steps should a reviewer take to reproduce or test the bug or new feature? Follow the same steps as in [PR#86 in Submitty/RainbowGrades](Submitty/RainbowGrades#86). ### Automated Testing & Documentation N/A (style change) ### Other information None
github-project-automation
Bot
moved this from Work in Progress
to Done
in Submitty Development
6 participants
Why is this Change Important & Necessary?
Partially addresses Issue #10273 In Submitty/Submitty
What is the New Behavior?
The leftmost 4 rows, which contain the User ID, Numeric ID, First Name, & Last Name, stay in place when scrolling to the right.
Before:
Before.mp4
After:
After.mp4
What steps should a reviewer take to reproduce or test the bug or new feature?
Edit: Since multiple people noted issues with testing this PR due to the changes existing in two different repositories, here are instructions for setting up Submitty to read the changes in the RainbowGrades repository.
git clone https://github.com/Submitty/RainbowGrades.gitin the directory above Submitty. The resulting file structure should look like:git checkout sticky-columnsgit checkout gradebook-format-fixvagrant halt, thenvagrant up, to link the RainbowGrades folder to the VM. If this worked correctly you should see the lineubuntu-22.04: /home/username_example/RCOS_Submitty/RainbowGrades => /usr/local/submitty/GIT_CHECKOUT/RainbowGradesvagrant ssh, the runsubmitty_install, to fetch re-compile rainbow grades.Automated Testing & Documentation
No testing or documentation is needed, as the change is purely visual.
Other information
Due to a small styling issue, I had to make a 1-line PR in the Submitty/Submitty repository, which can be found here. Reviewers should review both PR's simultaneously.