Skip to content

Commit b2703c8

Browse files
committed
reference apache#25957 at the nested-key branch of matchable_rows
1 parent a15bdda commit b2703c8

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

‎datafusion/physical-plan/src/joins/piecewise_merge_join/classic_join.rs‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -622,6 +622,8 @@ fn matchable_rows(
622622
return Ok(BooleanArray::new(BooleanBuffer::new_unset(num_rows), None));
623623
};
624624

625+
// The comparator's nested ordering is itself wrong for `<`/`<=` (#25957). Once that is
626+
// fixed, nested keys can go through `apply_cmp` too and this branch can be removed.
625627
if stream_values.data_type().is_nested() {
626628
let match_on_equal = matches_on_equal(operator)?;
627629
let cmp = JoinKeyComparator::new(

0 commit comments

Comments
 (0)