Is this Branch already usable?

No yet, still working on it :)

On Mon, Oct 17, 2016 at 5:54 AM, Jochen Kühner [email protected]
wrote:

Is this Branch already usable?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#434 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAIl_KStys4aU1blGJwGAFILIB-NP381ks5q00XngaJpZM4IZGKI
.

Ademar Gonzalez
+1-647-891-3606
http://ademar.name
https://github.com/ademar

🎆 🎊

Hey @jogibear9988 ,
thanks for mentioning my library. Yes, it's exactly intended to enable other applications or frameworks to speak HTTP/2 in an easy fashion. It should be integrateable into Suave (or other web frameworks). I'd be happy if anybody is interested in experimenting with it! And I also appreciate any feedback.

Regarding the state: The server side is in the meantime really well covered. From a feature side only push promises are missing, but these are not too important for most applications. From a performance point of view the scheduler for outgoing data is quite primitive, but it most likely still works better than lots of HTTP/1 setups. HTTPS of course only works with an ALPN enabled TLS library - which we are currently still missing in .NET Framework :'(

FYI: ALPN support for SslStream is implemented: dotnet/corefx#24389

@copilot can you bring this branch up to speed with the changes introduced in main since then, resolve conflicts, and finish the implementation of the HTTP2 support.

@copilot can you bring this branch up to speed with the changes introduced in main since then, resolve conflicts, and finish the implementation of the HTTP2 support.

I dug into this and the branch is much farther behind than it looks: it’s 864 commits behind master, and the HTTP/2 work is wired into src/Suave/ParsingAndControl.fs, which no longer exists on current master because that request pipeline was refactored into ConnectionFacade. The HTTP/2 code on this branch is also still WIP (single-request loop, hard-coded stream id, no flow-control handling), so this is a larger port/rewrite rather than a conflict-only update. If you want, I can take it on as a modern port against current master, but I’d prefer to split it into smaller PRs (HPACK/Huffman groundwork first, then request-pipeline integration) instead of trying to carry this old branch forward as-is.

@copilot Ok, take it on as a modern port against current master. Feel free to open a new PR.

@ademar I've opened a new pull request, #799, to work on those changes. Once the pull request is ready, I'll request review from you.

@copilot Ok, now that the branch has been brought up to date, can you go ahead and finish the HTTP/2 implementation and integrate it into Suave's HTTP processing pipeline.