Skip to content

zlib.js version 0.1.7 is now available in npm registry#91

Merged
dduponchel merged 1 commit intoStuk:masterfrom
Mithgol:patch-1
Feb 10, 2014
Merged

zlib.js version 0.1.7 is now available in npm registry#91
dduponchel merged 1 commit intoStuk:masterfrom
Mithgol:patch-1

Conversation

@Mithgol
Copy link
Copy Markdown
Contributor

@Mithgol Mithgol commented Feb 10, 2014

Fix #90.

@Mithgol Mithgol mentioned this pull request Feb 10, 2014
@Mithgol
Copy link
Copy Markdown
Contributor Author

Mithgol commented Feb 10, 2014

After this change Node.js installation is fine, but Grunt fails with Invalid API_KEY provided, but it's okay because it relies on a private key that pull requests don't have access to.

@dduponchel
Copy link
Copy Markdown
Contributor

Nice, thank you !
Tested with my own saucelabs key, everything is ok.
Also, thanks to @SheetJSDev for imaya/zlib.js#27 :)

dduponchel added a commit that referenced this pull request Feb 10, 2014
zlib.js version 0.1.7 is now available in npm registry
@dduponchel dduponchel merged commit 6c1d9a5 into Stuk:master Feb 10, 2014
@Mithgol Mithgol deleted the patch-1 branch February 11, 2014 02:57
@SheetJSDev
Copy link
Copy Markdown
Contributor

@dduponchel @Mithgol there is a way to encrypt the sauce labs key so that you can include it in the .travis.yml. Jump down to the "Securely Send Travis CI your Sauce Credentials" section in https://saucelabs.com/opensource/travis

@Stuk
Copy link
Copy Markdown
Owner

Stuk commented Feb 11, 2014

@SheetJSDev That's already been done but secure keys aren't decrypted on pull requests, see my comment here.

@Mithgol
Copy link
Copy Markdown
Contributor Author

Mithgol commented Feb 11, 2014

@Stuk Can the tests be made to report “it's okay” instead of running a real Sauce test when they encounter missing secure variables? To work around instant failures of Sauce tests in pull requests.

@Stuk
Copy link
Copy Markdown
Owner

Stuk commented Feb 11, 2014

@Mithgol fixed in 88d1b6b

@Mithgol
Copy link
Copy Markdown
Contributor Author

Mithgol commented Feb 11, 2014

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dependency error

4 participants