Skip to content

fix the build and the tests#86

Merged
dduponchel merged 5 commits intoStuk:masterfrom
dduponchel:update_build
Feb 3, 2014
Merged

fix the build and the tests#86
dduponchel merged 5 commits intoStuk:masterfrom
dduponchel:update_build

Conversation

@dduponchel
Copy link
Copy Markdown
Contributor

Update the build to fix some issues :

  • the travis build should now pass (and test the latest code)
  • the zlib.js license is clearly displayed and its sourceMappingURL has been removed.

When the travis job launches test-browser, the dist/ folder has not been
updated.
zlib.js is included in the generated files so we should display its
license in the headers.
@dduponchel
Copy link
Copy Markdown
Contributor Author

Failing build ? Strange...

@dduponchel
Copy link
Copy Markdown
Contributor Author

Travis says fetch failed http://packages:5984/colors/-/colors-0.3.0.tgz
I think we will have to wait for npm/npm#4584

@dduponchel
Copy link
Copy Markdown
Contributor Author

The npm issue is fixed but now the connection to saucelabs fails...
The travis build 37.2 added

$ export SAUCE_USERNAME=[secure]
$ export SAUCE_ACCESS_KEY=[secure]

but not this build (number 39.2).
@Stuk do you have an idea ?

I've launched the saucelabs tests on my side and they are all green. So the CI build is virtually ok !

dduponchel added a commit that referenced this pull request Feb 3, 2014
@dduponchel dduponchel merged commit 2c10077 into Stuk:master Feb 3, 2014
@dduponchel dduponchel deleted the update_build branch February 3, 2014 21:00
@Stuk
Copy link
Copy Markdown
Owner

Stuk commented Feb 3, 2014

Looks like they're now passing successfully: https://saucelabs.com/u/jszip Temporary glitch?

@Stuk
Copy link
Copy Markdown
Owner

Stuk commented Feb 3, 2014

Oh, I know what the problem is, Travis doesn't unencrypt the secure env vars for pull requests, because a malicious PR could expose them easily. However when the code gets merged into master the code is "safe" and so the tests run.

Pushing a (temporary) branch to this repo will also let the env vars get unencrypted and allow the Saucelabs tests to run

@dduponchel
Copy link
Copy Markdown
Contributor Author

Thank you for the explanation !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants