fix the build and the tests#86
Conversation
When the travis job launches test-browser, the dist/ folder has not been updated.
zlib.js is included in the generated files so we should display its license in the headers.
|
Failing build ? Strange... |
|
Travis says |
|
The npm issue is fixed but now the connection to saucelabs fails... but not this build (number 39.2). I've launched the saucelabs tests on my side and they are all green. So the CI build is virtually ok ! |
|
Looks like they're now passing successfully: https://saucelabs.com/u/jszip Temporary glitch? |
|
Oh, I know what the problem is, Travis doesn't unencrypt the secure env vars for pull requests, because a malicious PR could expose them easily. However when the code gets merged into master the code is "safe" and so the tests run. Pushing a (temporary) branch to this repo will also let the env vars get unencrypted and allow the Saucelabs tests to run |
|
Thank you for the explanation ! |
Update the build to fix some issues :