Fix deprecated Buffer constructor usage and add safeguards#506
Merged
Stuk merged 2 commits intoStuk:masterfrom Feb 21, 2019
Merged
Fix deprecated Buffer constructor usage and add safeguards#506Stuk merged 2 commits intoStuk:masterfrom
Stuk merged 2 commits intoStuk:masterfrom
Conversation
This avoids using Buffer constructor API on newer Node.js versions. To achieve that, Buffer.from presence is checked, with validating that it's not the same method as Uint8Array.from. Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
1. In allocBuffer(), ensure buffers allocated with new Buffer() are zero-filled. On newer Node.js versions, Buffer.alloc() zero-fills already. 2. In newBufferFrom(), throw when 'data' argument is a number. On newer Node.js versions, Buffer.from(number)/new Buffer(number, encooding) throw already.
Contributor
Author
|
Tracking: nodejs/node#19079 |
|
Ping @dduponchel? |
|
Is there any time line for addressing this issue please? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits here, one for moving off the deprecated Buffer constructor API, and the second for the additional safeguards (just in case).