Handle prepended data.#266
Merged
dduponchel merged 1 commit intoStuk:masterfrom Mar 21, 2016
Merged
Conversation
Contributor
Author
|
This pull request changes readers, like #252. Merging one means updating the other. |
dduponchel
force-pushed
the
crx_issue_265
branch
from
5f3c22e to
10dc634
Compare
dduponchel
force-pushed
the
crx_issue_265
branch
from
10dc634 to
b0e58c2
Compare
In some cases (crx files for example), data have been prepended but the offset didn't change: the previous version read 0 file, didn't check it and stopped. This version tries harder to recover from a bad offset. If/when we read 0 file, we will throw an error. Other tools (unzip, 7zip, etc) handle that case, now JSZip too. Fix Stuk#265.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases (crx files for example), data have been prepended but the
offset didn't change: the previous version read 0 file, didn't check it
and stopped.
This version tries harder to recover from a bad offset. If/when we read
0 file, we will throw an error.
Other tools (unzip, 7zip, etc) handle that case, now JSZip too.
Fix #265.