Add back removal of last period in multiattack parsing#41
Conversation
Merudo
commented
Sep 23, 2021
- The last period of Multiattack description is now removed again before being parsed
- The last period of Multiattack description is now removed again before being parsed
|
Ah, good initiative of you to make a PR for that last period! Thank you. However, since I was also working on something else (as you can read about in v0.3.9's release notes), I already re-added the lines that remove the period. That's what I was referring to in the review of your previous PR, but I wasn't very clear about it. 😅 Let me know if there are any bugs with v0.3.9 for your multiattack descriptions. In any case, I'll go ahead and close this PR. :) |
|
I think it makes more sense to remove the period after other HTML tags have been removed. That way the period gets deleted even if there is other formatting ( I'll keep this in mind while using Mob Tool, if an attack is not recognized I'll check if removing the period solves it :) |
|
That's a valid point. Even if you don't encounter situations where attacks aren't recognized, I might still follow your suggestion when I refactor |