Improve Multiattack parsing#39
Conversation
- Remove all HTML tags before parsing - Replace ` ` by space - Remove trailing whitespaces - Close Stendarpaval#38
Stendarpaval
left a comment
Stendarpaval
left a comment
There was a problem hiding this comment.
A nice, clean method of removing the influence of unexpected and/or unwanted HTML tags from interfering with multiattack parsing.
However, I prefer keeping lines 21 through 23 in, since they not only remove the trailing paragraph tag, but also the period at the end of the sentence. I vaguely remember that that period also causes issues with parsing multiattacks correctly, hence its removal.
So until I have time to further refactor the parsing algorithm, I prefer leaving that in. I'll probably merge your commit and then re-add these lines in the next commit.
|
Awesome! PR #41 adds back the removal of the last period, sorry for changing it. |
|
No worries! As you can read in my reply in PR #41, it's already taken care of. Thanks for helping me improve Mob Attack Tool :) |
2 participants
by space