gandi/livedns: Print actual changes to be pushed#546
Merged
tlimoncelli merged 2 commits intoStackExchange:masterfrom Aug 26, 2019
rdalverny:gandi-changesoutput
Merged
gandi/livedns: Print actual changes to be pushed#546tlimoncelli merged 2 commits intoStackExchange:masterfrom rdalverny:gandi-changesoutput
tlimoncelli merged 2 commits intoStackExchange:masterfrom
rdalverny:gandi-changesoutput
Conversation
Currently, preview & push output prints all domain records values:
$ dnscontrol preview
----- DNS Provider: gandi...1 correction
#1: Setting dns records for example.com:
mail.example.com.
1.2.3.4
"ga"
"bu"
"zo"
With this change, it would only show what changes from current state:
$ dnscontrol preview
----- DNS Provider: gandi...1 correction
#1: Setting dns records for example.com:
CREATE TXT ga.example.com "ga" ttl=10800
MODIFY TXT bu.example.com "bu" ttl=10800
DELETE TXT meu.example.com "meu" ttl=10800
rblenkinsopp
pushed a commit
to rblenkinsopp/dnscontrol
that referenced
this pull request
Aug 21, 2020
* gandi/livedns: Print actual changes to be pushed
Currently, preview & push output prints all domain records values:
$ dnscontrol preview
----- DNS Provider: gandi...1 correction
StackExchange#1: Setting dns records for example.com:
mail.example.com.
1.2.3.4
"ga"
"bu"
"zo"
With this change, it would only show what changes from current state:
$ dnscontrol preview
----- DNS Provider: gandi...1 correction
StackExchange#1: Setting dns records for example.com:
CREATE TXT ga.example.com "ga" ttl=10800
MODIFY TXT bu.example.com "bu" ttl=10800
DELETE TXT meu.example.com "meu" ttl=10800
* Add import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, preview & push actions print all domain records values that will be pushed:
With this change, it would only show what changes from current remote state (and other provider plugins do - this feels more consistent):