BUILD: Fix bug preventing macOS binaries from being signed and notarized with an Apple Developer ID#4135
Merged
tlimoncelli merged 2 commits intoStackExchange:mainfrom Mar 7, 2026
Conversation
…t project name ID.
- The `.p8` key must be base64-encoded, not passed as raw PEM content. Updated the secrets table, encoding instructions, and test example.
tlimoncelli
approved these changes
Mar 7, 2026
tlimoncelli
changed the title
id: build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
notarize.macossection in.goreleaser.ymlwas silently skipped during the v4.36.0 release build:sign & notarize macOS binaries pipe skipped or partially skipped reason=no darwin binaries found with ids: dnscontrolThe notarize section defaults to looking for darwin binaries matching the project name ID (
dnscontrol), but the build had an explicitid: build, causing the mismatch.Remove all explicit
id: buildreferences and rely on the GoReleaser default ID (which isproject_name, i.e.dnscontrol). This is the convention for single-build projects. Three references removed:builds[0].iduniversal_binaries[0].iddockers_v2[0].idsAlso fixes the documentation:
MACOS_NOTARY_KEYmust be base64-encoded, not passed as raw PEM content.• skipping validate... • cleaning distribution directory • loading environment variables • getting and validating git state • git state commit=05e6479ff4fd74c62b3d8f0e56ed0fa9f7d34d3e branch=build/goreleaser-signing-notarization current_tag=v4.36.0 previous_tag=v4.35.0 dirty=true • pipe skipped or partially skipped reason=disabled during snapshot mode • parsing tag • setting defaults • snapshotting • building snapshot... version=4.36.1-next • running before hooks • running hook=go fmt ./... • running hook=go mod tidy • running hook=go generate ./... • ensuring distribution directory • setting up metadata • writing release metadata • loading go mod information • build prerequisites • building binaries • building binary=dist/dnscontrol_freebsd_arm64_v8.0/dnscontrol • building binary=dist/dnscontrol_darwin_amd64_v1/dnscontrol • building binary=dist/dnscontrol_linux_arm64_v8.0/dnscontrol • building binary=dist/dnscontrol_darwin_arm64_v8.0/dnscontrol • building binary=dist/dnscontrol_windows_amd64_v1/dnscontrol.exe • building binary=dist/dnscontrol_windows_arm64_v8.0/dnscontrol.exe • building binary=dist/dnscontrol_linux_amd64_v1/dnscontrol • building binary=dist/dnscontrol_freebsd_amd64_v1/dnscontrol • universal binaries • creating from 2 binaries id=dnscontrol binary=dist/dnscontrol_darwin_all/dnscontrol • sign & notarize macOS binaries • signing binary=dist/dnscontrol_darwin_all/dnscontrol • sending notarize request binary=dist/dnscontrol_darwin_all/dnscontrol • notarize still pending binary=dist/dnscontrol_darwin_all/dnscontrol • took: 12s • writing artifacts metadata • build succeeded after 20s • thanks for using GoReleaser!Fixes #4117