CICD: Restrict permissions in .github/workflows/pr_integration_tests.yml#4123
Merged
tlimoncelli merged 1 commit intomainfrom Mar 2, 2026
Merged
CICD: Restrict permissions in .github/workflows/pr_integration_tests.yml#4123tlimoncelli merged 1 commit intomainfrom
tlimoncelli merged 1 commit intomainfrom
Conversation
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
tlimoncelli
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/StackExchange/dnscontrol/security/code-scanning/38
In general, this issue is fixed by adding an explicit
permissionsblock for the GITHUB_TOKEN at the workflow root or at each job, restricting it to the minimum scopes needed. For a typical test workflow that only checks out code, uses cache, and uploads artifacts,contents: readis sufficient.For this specific workflow in
.github/workflows/pr_integration_tests.yml, the simplest non-invasive fix is to add a top-levelpermissionsblock right after thename:(or beforejobs:). The jobs useactions/checkout,actions/cache, andactions/upload-artifact, none of which require write access to repository contents. Therefore, we can safely set:This will apply to all jobs (
integration-test-providersandintegration-tests) since they do not define their ownpermissions. No other changes, imports, or definitions are needed.Suggested fixes powered by Copilot Autofix. Review carefully before merging.