Ken Thompson (co-creater of C and Unix) once said, "One of my most productive days was throwing away 1000 lines of code."

Glad to see the shift to CNR is complete! Thanks for cleaning up Hexonet!

CC @cafferata in case there are docs and other references that need to be cleaned up.

After reviewing the full codebase, the following files still contain Hexonet references that should be cleaned up as part of this removal:

Documentation

• documentation/SUMMARY.md (line 147): Navigation entry [HEXONET](provider/hexonet.md) in the GitBook table of contents.
• documentation/provider/index.md (line 437): Provider table row listing HEXONET with maintainer @KaiSchwarz-cnic.
• documentation/commands/creds-json.md (lines 21–26, 34, 44, 237): Hexonet used as example in creds.json documentation (example config block, env variable references).
• documentation/advanced-features/byo-secrets.md (line 77): HEXONET listed in the PROVIDERS array.
• documentation/advanced-features/writing-providers.md (line 314): HEXONET listed in the PROVIDERS array.
• documentation/.gitbook.yaml (line 28): Redirect entry service-providers/providers/hexonet: provider/hexonet.md.

CI / Build

• .github/workflows/pr_integration_tests.yml (lines 55, 93, 168–170): HEXONET in the PROVIDERS list, plus HEXONET_DOMAIN, HEXONET_ENTITY, HEXONET_PW, HEXONET_UID environment variable mappings.
• .goreleaser.yml (line 42): hexonet in the changelog provider-specific regexp pattern.

Integration tests

• integrationTest/integration_test.go (lines 663, 686, 703): HEXONET entries in test provider lists (one active, two commented out).
• integrationTest/profiles.json (lines 201–208): HEXONET test profile configuration block.

Other

• README.md (lines 45, 86): HEXONET listed twice in the provider lists.

Thanks for the review, we have removed the hexonet references from other files as well. Please review again :) ty

Looks good! All hexonet references from the previous review have been addressed. Nice touch replacing the creds-json.md example with CNR.

One minor suggestion: consider updating .gitbook.yaml to redirect the old hexonet URL to the CNR page instead of removing it entirely. That way, anyone following an old link like https://docs.dnscontrol.org/provider/hexonet would land on https://docs.dnscontrol.org/provider/cnr instead of a 404. This can also be done in a follow-up.

Thanks for the quick review, and that was a great idea, we have added a entry into .gitbook.yaml it should load CNR data now instead of showing 404.

The entry we added:
service-providers/providers/hexonet: provider/cnr.md

Thanks again!

Looks good! Please rebase and fix conflicts. Thanks for contributing this!

Looks good! Please rebase and fix conflicts. Thanks for contributing this!

Thanks for the review! Rebased and fixed the conflicts 👍🏼

Thanks!