Skip to content

CICD: Split pr_check_git_status into separate jobs for better PR feedback#4079

Merged
tlimoncelli merged 3 commits intoStackExchange:mainfrom
cafferata:cicd/split-pr-check-git-status
Feb 13, 2026
Merged

CICD: Split pr_check_git_status into separate jobs for better PR feedback#4079
tlimoncelli merged 3 commits intoStackExchange:mainfrom
cafferata:cicd/split-pr-check-git-status

Conversation

@cafferata
Copy link
Copy Markdown
Collaborator

@cafferata cafferata commented Feb 12, 2026 •
edited
Loading

A change I've been wanting to make for a while! Now each check shows up individually in the PR checks UI.

@cafferata cafferata marked this pull request as draft February 12, 2026 20:16
@cafferata cafferata force-pushed the cicd/split-pr-check-git-status branch from 8112ca4 to f358ef9 Compare February 12, 2026 20:19
@cafferata cafferata added Category: Documentation build Pull requests that updates CI code github_actions Pull requests that update Github_actions code labels Feb 12, 2026
@cafferata
Copy link
Copy Markdown
Collaborator Author

cafferata commented Feb 12, 2026

Ready for review. 🤓

@cafferata cafferata marked this pull request as ready for review February 12, 2026 20:25
@tlimoncelli
Copy link
Copy Markdown
Contributor

tlimoncelli commented Feb 13, 2026

A very welcome change! Thank you!

@tlimoncelli
Copy link
Copy Markdown
Contributor

tlimoncelli commented Feb 13, 2026

I've added linting steps to bin/generate-all.sh (which means the filename is no longer 100% accurate). Would you add the go fix and golangci-lint (and maybe staticcheck... I don't know if I'm going to keep that one) checks too?

@tlimoncelli tlimoncelli merged commit 86e9d52 into StackExchange:main Feb 13, 2026
37 checks passed
@cafferata cafferata deleted the cicd/split-pr-check-git-status branch February 13, 2026 15:57
@cafferata
Copy link
Copy Markdown
Collaborator Author

cafferata commented Feb 13, 2026

Sorry, I'm not entirely sure I understand your request. go fix is already included in .github/workflows/pr_check_git_status.yml, and golangci-lint is already included in .github/workflows/pr_lint.yml.

The only one currently missing from CI is staticcheck, which could be added to .github/workflows/pr_lint.yml, though you mentioned you're not sure yet whether you want to keep that one.

Could you clarify if there are any actions you'd still like me to take?

@tlimoncelli
Copy link
Copy Markdown
Contributor

tlimoncelli commented Feb 13, 2026

Disregard my message. The only missing part is staticcheck and we don't need it. (Sorry, I'm having a hell of a morning... including a flat tire and other problems.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

build Pull requests that updates CI code Category: Documentation github_actions Pull requests that update Github_actions code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cafferata @tlimoncelli