AKAMAIEDGEDNS: Akamai Openedgegrid golang v12.3.0 update(#4067), AKAMAICDN and CNAME on the same hostname(#2959), Support wrapped errors(#3314)#4070
Merged
tlimoncelli merged 11 commits intoStackExchange:mainfrom Feb 11, 2026
Conversation
…aiedgedns doc, allow cname and AKAMAICDN to have same name
…dnscontrol into akamaiedgedns_4067_AkamaiOPENedgegrid-golang_v12.3.0_update
tlimoncelli
suggested changes
Feb 11, 2026
Contributor
tlimoncelli
left a comment
tlimoncelli
left a comment
There was a problem hiding this comment.
2 minor nits. Otherwise, all good!
Thanks for the very clean PR. (and might I add... it's great to have a vendor maintain their own provider. It is rare and very appreciated!)
Thanks so much!
| } | ||
|
|
||
| queryArgs := dnsv2.ZoneQueryString{} | ||
| //queryArgs := dns.ZoneQueryString{} |
Contributor
There was a problem hiding this comment.
Delete this line?
Suggested change
| //queryArgs := dns.ZoneQueryString{} |
| // initialize initializes the "Akamai OPEN EdgeGrid" library. | ||
| func initialize(clientSecret string, host string, accessToken string, clientToken string) { | ||
| eg := edgegrid.Config{ | ||
| // initialize initializes the "Akamai OPEN EdgeGrid" library |
Contributor
There was a problem hiding this comment.
End comments with ".".
Suggested change
| // initialize initializes the "Akamai OPEN EdgeGrid" library | |
| // initialize initializes the "Akamai OPEN EdgeGrid" library. |
Contributor
There was a problem hiding this comment.
$ golangci-lint run ./...
providers/akamaiedgedns/akamaiEdgeDnsService.go:23:1: Comment should end in a period (godot)
// initialize initializes the "Akamai OPEN EdgeGrid" library
…dnscontrol into akamaiedgedns_4067_AkamaiOPENedgegrid-golang_v12.3.0_update
Contributor
Author
|
@tlimoncelli changes made |
Contributor
|
Thanks so much! |
tlimoncelli
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.