Skip to content

REFACTOR: Fix golint warnings#4060

Merged
tlimoncelli merged 2 commits intomainfrom
tlim_lint
Feb 9, 2026
Merged

REFACTOR: Fix golint warnings#4060
tlimoncelli merged 2 commits intomainfrom
tlim_lint

Conversation

@tlimoncelli
Copy link
Copy Markdown
Contributor

Fixing these:

$ golint ./...
commands/cmdzonecache.go:10:24: exported func NewCmdZoneCache returns unexported type *commands.cmdZoneCache, which can be annoying to use
integrationTest/helpers_integration_test.go:406:26: func parameter pullZoneId should be pullZoneID
pkg/dnsgraph/dnsgraph.go:121:1: receiver name nodes should be consistent with previous receiver name graph for invalid-type
pkg/dnsgraph/dnsgraph.go:134:1: receiver name edges should be consistent with previous receiver name graph for invalid-type
pkg/dnsgraph/dnsgraph.go:147:1: receiver name edges should be consistent with previous receiver name graph for invalid-type
pkg/rtypecontrol/stringify.go:8:1: exported function StringifyQuoted should have comment or be unexported
pkg/transform/ptr.go:70:31: don't use underscores in Go names; func parameter ip_ should be ip
providers/bunnydns/api.go:45:2: struct field PullZoneId should be PullZoneID
providers/bunnydns/convert.go:45:3: var pullZoneId should be pullZoneID
providers/cloudns/adaptiveLimiter.go:10:6: exported type AdaptiveLimiter should have comment or be unexported
providers/cloudns/adaptiveLimiter.go:14:1: exported function NewAdaptiveLimiter should have comment or be unexported
providers/cloudns/adaptiveLimiter.go:20:1: exported method AdaptiveLimiter.Wait should have comment or be unexported
providers/cloudns/cloudnsProvider.go:28:1: exported function NewCloudns should have comment or be unexported
providers/cloudns/cloudnsProvider.go:28:39: exported func NewCloudns returns unexported type *cloudns.cloudnsProvider, which can be annoying to use
providers/cloudns/cloudnsProvider.go:41:1: exported function NewDsp should have comment or be unexported
providers/cloudns/cloudnsProvider.go:45:1: exported function NewReg should have comment or be unexported
providers/sakuracloud/api.go:273:74: exported func NewSakuracloudAPI returns unexported type *sakuracloud.sakuracloudAPI, which can be annoying to use

But not these, as they seem to be errors due to the fact that golint doesn't understand generics:

pkg/dnsgraph/dnsgraph.go:121:1: receiver name nodes should be consistent with previous receiver name graph for invalid-type
pkg/dnsgraph/dnsgraph.go:134:1: receiver name edges should be consistent with previous receiver name graph for invalid-type
pkg/dnsgraph/dnsgraph.go:147:1: receiver name edges should be consistent with previous receiver name graph for invalid-type

@tlimoncelli tlimoncelli merged commit 7b6b8ee into main Feb 9, 2026
20 checks passed
@tlimoncelli tlimoncelli deleted the tlim_lint branch February 9, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant