Skip to content

INWX: Bugfix: NAMESERVER() should replace registrar list, not merge into it#4052

Merged
tlimoncelli merged 2 commits intoStackExchange:mainfrom
axeldunkel:main
Feb 5, 2026
Merged

INWX: Bugfix: NAMESERVER() should replace registrar list, not merge into it#4052
tlimoncelli merged 2 commits intoStackExchange:mainfrom
axeldunkel:main

Conversation

@axeldunkel
Copy link
Copy Markdown
Contributor

Summary

Fixes the INWX registrar provider to replace nameservers instead of merging existing and desired nameservers.

Problem

The GetRegistrarCorrections() function was merging the currently registered nameservers with the desired nameservers from the configuration. This caused nameserver updates to fail when migrating a domain from one DNS provider to another.

Example failure:
Update nameservers arely.ns.cloudflare.com,pablo.ns.cloudflare.com -> arely.ns.cloudflare.com,ns.inwx.de,ns2.inwx.de,ns3.inwx.eu,pablo.ns.cloudflare.com
FAILURE! (2306)

Solution

Changed the logic to use only the configured nameservers (dc.Nameservers) instead of creating a union with the existing registrar nameservers.

Before

combined := map[string]bool{}
for _, ns := range dc.Nameservers {
    combined[ns.Name] = true
}
for _, rs := range regNameservers {
    combined[rs] = true
}

After

var expected []string
for _, ns := range dc.Nameservers {
    expected = append(expected, ns.Name)
}

axeldunkel and others added 2 commits February 3, 2026 17:58
## Summary

Fixes the INWX registrar provider to replace nameservers instead of merging existing and desired nameservers.

## Problem

The `GetRegistrarCorrections()` function was merging the currently registered nameservers with the desired nameservers from the configuration. This caused nameserver updates to fail when migrating a domain from one DNS provider to another.
Copy link
Copy Markdown
Contributor

@tlimoncelli tlimoncelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I think a lot of the older providers were inconsistent about merging vs. replacing. The new standard should be: If no NAMESERVER() statements exist, leave them alone. If even 1 exists, replace the nameservers.

@tlimoncelli tlimoncelli changed the title fix(inwx): Replace nameservers instead of merging them INWX: Bugfix: NAMESERVER() should replace registrar list, not merge into it Feb 5, 2026
@tlimoncelli tlimoncelli merged commit 6d2074b into StackExchange:main Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants