INWX: Bugfix: NAMESERVER() should replace registrar list, not merge into it#4052
Merged
tlimoncelli merged 2 commits intoStackExchange:mainfrom Feb 5, 2026
Merged
INWX: Bugfix: NAMESERVER() should replace registrar list, not merge into it#4052tlimoncelli merged 2 commits intoStackExchange:mainfrom
tlimoncelli merged 2 commits intoStackExchange:mainfrom
Conversation
## Summary Fixes the INWX registrar provider to replace nameservers instead of merging existing and desired nameservers. ## Problem The `GetRegistrarCorrections()` function was merging the currently registered nameservers with the desired nameservers from the configuration. This caused nameserver updates to fail when migrating a domain from one DNS provider to another.
tlimoncelli
reviewed
Feb 3, 2026
Contributor
tlimoncelli
left a comment
There was a problem hiding this comment.
Good point. I think a lot of the older providers were inconsistent about merging vs. replacing. The new standard should be: If no NAMESERVER() statements exist, leave them alone. If even 1 exists, replace the nameservers.
tlimoncelli
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the INWX registrar provider to replace nameservers instead of merging existing and desired nameservers.
Problem
The
GetRegistrarCorrections()function was merging the currently registered nameservers with the desired nameservers from the configuration. This caused nameserver updates to fail when migrating a domain from one DNS provider to another.Example failure:
Update nameservers arely.ns.cloudflare.com,pablo.ns.cloudflare.com -> arely.ns.cloudflare.com,ns.inwx.de,ns2.inwx.de,ns3.inwx.eu,pablo.ns.cloudflare.com
FAILURE! (2306)
Solution
Changed the logic to use only the configured nameservers (
dc.Nameservers) instead of creating a union with the existing registrar nameservers.Before
After