BUGFIX: fix regression on a SPF parsing#3994
Merged
tlimoncelli merged 1 commit intoStackExchange:mainfrom Jan 21, 2026
Merged
Conversation
Contributor
|
Thanks for finding and fixing this! |
tlimoncelli
changed the title
Contributor
|
Emergency bug-fix release shipped: https://github.com/StackExchange/dnscontrol/releases/tag/v4.31.1 Thanks, Jenn! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
819253a seems to have caused a regression in the parsing of
amechanism SPF parts, e.g. a part likea:something.wm.eduwould now returnERROR: unsupported SPF part a:something.wm.edu. This reverts back to the useHasPrefixto prevent those parts from erroring.Parsing this way wouldn't error on bad parts like
asdf:something.wm.edu, so maybe a larger fix is needed, but for now just fixing the regression seemed simplest.