DIGITALOCEAN: Update feature table for provider#3958
Merged
tlimoncelli merged 2 commits intoStackExchange:mainfrom Jan 6, 2026
Merged
Conversation
Contributor
|
Yes, please run |
Collaborator
Author
I had already done that. After that, I wasn't clear whether |
tlimoncelli
changed the title
This was referenced Jan 6, 2026
tlimoncelli
pushed a commit
that referenced
this pull request
Jan 29, 2026
) #3958 updated the digitalocean provider to make all of the feature flags explicit. Later I noticed that `Cannot()` can take an argument so that the reason for it can be seen by the end user. So now I have moved the reason into the argument instead of leaving it as a code-level comment. - `dnscontrol` rebuilt fine - `bin/generate-all.sh` picked up an unrelated file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR clarifies the DigitalOcean provider's capabilities by replacing question marks (
❔) with explicit feature flags in both the provider code and documentation tables.Changes
providers/digitalocean/digitaloceanProvider.goto explicitly declare support or lack of support for 15 additional record types and featuresdocumentation/provider/index.mdto reflect these explicit capabilities in the provider feature tablesFeatures Now Explicitly Documented
Supported:
Not Supported (per DigitalOcean docs):
Testing was done
These are documentation/capability declaration changes only - no functional code changes. Unit tests ran locally without errors and the docs generated without errors.
The capabilities system will now properly validate configurations against DigitalOcean's actual limitations.
Something to consider
The
commands/types/dnscontrol.d.tsfile changes during documentation generation, but I haven't added that to this PR because it seems unrelated. Claude also thinks that this file is why thecheck-git-statusGHA is failing. Should I go ahead and add this file to prevent this from tripping up future PRs?🤖 PR summary initially generated with Claude Code
Co-Authored-By: Claude Sonnet 4.5 [email protected]