BUNNYDNS: Add SVCB and HTTPS support#3937
Conversation
|
Hello friend! The merging/separating Tager/Params looks fine by me! As far as tests 17 and 19. You can add functions for HttpsHasNullTarget / ScvbHasNullTarget yourself. I'd recommend putting them in pkg/rejectif/httpsscvb.go (a new file). The testing framework should automatically skip the "Change HTTPS params-empty" step. Look at other rejectif/*.go files for examples. |
|
Friendly ping? |
|
Apologies for the delay, got a tad busy. Will get back to this later today :) |
jeda
force-pushed
the
bunnydns-add-svcb-and-https
branch
from
ebd94ee to
623e33b
Compare
|
Looks like after some discussion with support, they've eased their record parser, and now the tests pass. No need to do further adjustments to dnscontrol, so this should be good to go. I've rebased the commit based on the latest |
|
Fantastic! Thanks for reaching out to the provider to get this resolved! |
3 participants
This Pull Requests adds support for the SVCB and HTTPS records to the BUNNY_DNS provider.
Value). Happy to hear any feedback about this.Tests work... except for17:HTTPS:Change_HTTPS_params-emptyand19:SVCB:Change_SVCB_params-empty- but this is a requirement from Bunny.net's side. Not sure if there's anything that needs to be added to dnscontrol to handle this scenario. (This would be something forauditrecords.go, but there's no module for SVCB/HTTPS that I can see)