GANDI_V5: BUGFIX: Uppercase labels fail to update#3582
Merged
tlimoncelli merged 2 commits intomainfrom May 22, 2025
Merged
Conversation
tlimoncelli
changed the title
AsifNawaz-cnic
pushed a commit
to centralnicgroup-opensource/rtldev-middleware-dnscontrol
that referenced
this pull request
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3581
Issue
DNSControl attempts to lowercase all labels (See Opinion #4 in https://docs.dnscontrol.org/developer-info/opinions).
Sadly, the Gandi API has a bug (I consider it a bug) that to update the records at a particular label, the request must specify the label with the same case as what is stored at Gandi. In other words, the update API does not use a case-insensitive comparison when looking up the label being updated.
Resolution
Luckily we save the record as it came from the API in
.Original. We can use that to specify the label that Gandi expects.