NEW REGISTRAR: Dynadot (DYNADOT)#2753
Merged
tlimoncelli merged 3 commits intoStackExchange:masterfrom Jan 2, 2024
Merged
Conversation
e-im
commented
Jan 1, 2024
tlimoncelli
approved these changes
Jan 2, 2024
Contributor
|
Thank you for contributing this new registrar! Please be sure to join the https://groups.google.com/g/dnscontrol-discuss email list so you stay up to date with any big announcements. |
PJEilers
pushed a commit
to realtimeregister/dnscontrol
that referenced
this pull request
Jan 8, 2024
Co-authored-by: Tom Limoncelli <[email protected]>
Collaborator
|
@tlimoncelli can you create the label |
Contributor
|
provider-DYNADOT created! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added support for Dynadot as a registrar. They do not have an official (or any community) go package for their API, so I have implemented a small subset manually. I based the implementation on the existing internet.bs and easyname providers.
Dynadot API docs
They do provide a JSON API (replace
.xmlwith.jsonin the url), however it is quite odd and I suspect internally may just be converting XML to JSON after the response has been generated, yielding weird results. As such I have used the XML API.I have tested this manually. I'm happy to provide a test API key if necessary.