Skip to content

CHORE: Fix golint and staticcheck errors/warnings#2717

Merged
tlimoncelli merged 2 commits intomasterfrom
tlim_ioutil
Dec 11, 2023
Merged

CHORE: Fix golint and staticcheck errors/warnings#2717
tlimoncelli merged 2 commits intomasterfrom
tlim_ioutil

Conversation

@tlimoncelli
Copy link
Copy Markdown
Contributor

No description provided.

@tlimoncelli tlimoncelli changed the title CORE: Fix golint and staticcheck errors/warnings CHORE: Fix golint and staticcheck errors/warnings Dec 11, 2023
@tlimoncelli
Copy link
Copy Markdown
Contributor Author

I'd normally wait for folks to approve these changes but they are just comments or replacing one function for its fully-compatible replacement.

CC @tomfitzhenry @xddxdd: Changed ioutil.ReadAll() to io.ReadAll()

providers/gcore/gcoreExtend.go:7:2: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details.  (SA1019)
providers/mythicbeasts/mythicbeastsProvider.go:10:2: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details.  (SA1019)

CC @imlonghao: Changed variable "client" to "c".

providers/porkbun/porkbunProvider.go:83:27: methods on the same type should have the same receiver name (seen 13x "c", 1x "client") (ST1016)

CC @blackshadev : Added a ton of comments to DNSGraph.

pkg/dnsgraph/dependencies.go:3:1: exported function CreateDependencies should have comment or be unexported
pkg/dnsgraph/dnsgraph.go:8:2: exported const IncomingEdge should have comment (or a comment on this block) or be unexported
pkg/dnsgraph/dnsgraph.go:12:6: exported type DNSGraphEdge should have comment or be unexported
pkg/dnsgraph/dnsgraph.go:12:6: type name will be used as dnsgraph.DNSGraphEdge by other packages, and that stutters; consider calling this Edge
pkg/dnsgraph/dnsgraph.go:18:6: exported type DNSGraphEdges should have comment or be unexported
pkg/dnsgraph/dnsgraph.go:18:6: type name will be used as dnsgraph.DNSGraphEdges by other packages, and that stutters; consider calling this Edges
pkg/dnsgraph/dnsgraph.go:20:6: exported type DNSGraphNode should have comment or be unexported
pkg/dnsgraph/dnsgraph.go:20:6: type name will be used as dnsgraph.DNSGraphNode by other packages, and that stutters; consider calling this Node
pkg/dnsgraph/dnsgraph.go:27:6: exported type DNSGraph should have comment or be unexported
pkg/dnsgraph/dnsgraph.go:32:1: exported function CreateGraph should have comment or be unexported
pkg/dnsgraph/dnsgraph.go:110:1: receiver name nodes should be consistent with previous receiver name graph for invalid-type
pkg/dnsgraph/dnsgraph.go:122:1: receiver name edges should be consistent with previous receiver name graph for invalid-type
pkg/dnsgraph/dnsgraph.go:134:1: receiver name edges should be consistent with previous receiver name graph for invalid-type
pkg/dnsgraph/graphable.go:3:6: exported type NodeType should have comment or be unexported
pkg/dnsgraph/graphable.go:6:2: exported const Change should have comment (or a comment on this block) or be unexported
pkg/dnsgraph/graphable.go:10:6: exported type DependencyType should have comment or be unexported
pkg/dnsgraph/graphable.go:13:2: exported const ForwardDependency should have comment (or a comment on this block) or be unexported
pkg/dnsgraph/graphable.go:17:6: exported type Dependency should have comment or be unexported
pkg/dnsgraph/graphable.go:22:6: exported type Graphable should have comment or be unexported
pkg/dnsgraph/graphable.go:28:1: exported function GetRecordsNamesForGraphables should have comment or be unexported
pkg/dnsgraph/testutils/stubrecords.go:5:6: exported type StubRecord should have comment or be unexported
pkg/dnsgraph/testutils/stubrecords.go:11:1: exported method StubRecord.GetType should have comment or be unexported
pkg/dnsgraph/testutils/stubrecords.go:15:1: exported method StubRecord.GetName should have comment or be unexported
pkg/dnsgraph/testutils/stubrecords.go:19:1: exported method StubRecord.GetDependencies should have comment or be unexported
pkg/dnsgraph/testutils/stubrecords.go:23:1: exported function StubRecordsAsGraphable should have comment or be unexported
pkg/dnssort/result.go:5:6: exported type SortResult should have comment or be unexported

Tom

@tlimoncelli tlimoncelli merged commit 790513a into master Dec 11, 2023
@tlimoncelli tlimoncelli deleted the tlim_ioutil branch December 11, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant