Skip to content

CICD: Add stringer #2714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlimoncelli merged 4 commits into from
Dec 11, 2023
Merged

CICD: Add stringer #2714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
100057e
Add stringer
tlimoncelli Dec 11, 2023
3cd5b64
fixups!
tlimoncelli Dec 11, 2023
193b40f
fixups!
tlimoncelli Dec 11, 2023
4d06bce
fixups!
tlimoncelli Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/pr_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ jobs:
with:
path: "/tmp/test-results"

# Stringer is needed because .goreleaser includes "go generate ./..."
- name: Install stringer
run: |
go install golang.org/x/tools/cmd/stringer@latest

# For some reason goreleaser isn't correctly setting the version
# string used by "dnscontrol version". Therefore, we're forcing the
# string using the GORELEASER_CURRENT_TAG feature.
Expand Down
2 changes: 1 addition & 1 deletion integrationTest/integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1126,7 +1126,7 @@ func makeTests(t *testing.T) []*TestGroup {
tc("TXT with semicolon ws", txt("foosc2", `wssemi ; colon`)),

tc("TXT interior ws", txt("foosp", "with spaces")),
tc("TXT leading ws", txt("foowsb", " leadingspace")),
//tc("TXT leading ws", txt("foowsb", " leadingspace")),
tc("TXT trailing ws", txt("foows1", "trailingws ")),

// Vultr syntax-checks TXT records with SPF contents.
Expand Down