Skip to content

CICD: Fixed go install command#2712

Merged
tlimoncelli merged 2 commits intoStackExchange:masterfrom
cafferata:cicd/unit-test-go-install-go-embed
Dec 11, 2023
Merged

CICD: Fixed go install command#2712
tlimoncelli merged 2 commits intoStackExchange:masterfrom
cafferata:cicd/unit-test-go-install-go-embed

Conversation

@cafferata
Copy link
Copy Markdown
Collaborator

@cafferata cafferata commented Dec 10, 2023

Summary

After the refactor from #2704 the file dnscontrol.d.ts for the go install command is missing. Which is (also) needed for the GitHub unit tests, see actions/runs/7158752208/job/19491197407. This has been temporarily resolved by reintroducing the dnscontrol.d.ts file.

git checkout 9014c6879c46e6e96de4282f344694fbdeb65ca7 -- commands/types/dnscontrol.d.ts

Why temporary?
Because now still a local git diff will be created after running go generate ./... command. Which is mentioned in the documentation and/or GitHub pull request template. For now my focus was to get a working GitHub CI so that successful builds can be made.

I will have to look further into splitting/fixing //go:embed when initializing go install. This is an impact that I did not foresee.

Ah! It's not the GoReleaser build. It's go install for unit tests.

Reproducible case

rm -rf commands/types/dnscontrol.d.ts
go install
commands/writeTypes.go:40:12: pattern types/dnscontrol.d.ts: no matching files found

#2704 (comment)

@tlimoncelli
Copy link
Copy Markdown
Contributor

Thanks!

@tlimoncelli tlimoncelli merged commit 3ad9560 into StackExchange:master Dec 11, 2023
@cafferata cafferata deleted the cicd/unit-test-go-install-go-embed branch December 11, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants