CICD: Fixed go install command#2712
Merged
tlimoncelli merged 2 commits intoStackExchange:masterfrom Dec 11, 2023
Merged
Conversation
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After the refactor from #2704 the file
dnscontrol.d.tsfor thego installcommand is missing. Which is (also) needed for the GitHub unit tests, see actions/runs/7158752208/job/19491197407. This has been temporarily resolved by reintroducing thednscontrol.d.tsfile.Why temporary?
Because now still a local git diff will be created after running
go generate ./...command. Which is mentioned in the documentation and/or GitHub pull request template. For now my focus was to get a working GitHub CI so that successful builds can be made.I will have to look further into splitting/fixing
//go:embedwhen initializinggo install. This is an impact that I did not foresee.#2704 (comment)