TRANSIP: Fix TXT quoting#2708
Merged
tlimoncelli merged 7 commits intoStackExchange:masterfrom Dec 11, 2023
Merged
Conversation
cafferata
approved these changes
Dec 10, 2023
Collaborator
|
Looks good! I did different test cases 👍 git remote add blackshadev [email protected]:blackshadev/dnscontrol.git
git fetch blackshadev
git checkout -b fix-quoting --track blackshadev/fix-quoting
go builddnscontrol preview --domains jcid.nl |
Collaborator
Author
So is this a good thing? Did |
Collaborator
|
Your comment and my edit crossed paths. Fix looks good to me. I had already given a GitHub approval in advance. 👍 |
tlimoncelli
reviewed
Dec 10, 2023
Co-authored-by: Tom Limoncelli <[email protected]>
tlimoncelli
reviewed
Dec 11, 2023
tlimoncelli
reviewed
Dec 11, 2023
tlimoncelli
reviewed
Dec 11, 2023
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes !2702