CICD: GoReleaser generates TypeScript file#2704
Merged
tlimoncelli merged 3 commits intoStackExchange:masterfrom Dec 10, 2023
Merged
CICD: GoReleaser generates TypeScript file#2704tlimoncelli merged 3 commits intoStackExchange:masterfrom
tlimoncelli merged 3 commits intoStackExchange:masterfrom
Conversation
This was referenced Dec 10, 2023
tlimoncelli
added a commit
that referenced
this pull request
Dec 10, 2023
Co-authored-by: Tom Limoncelli <[email protected]>
Contributor
Collaborator
Author
|
Interesting! Because I have not seen this output before. I check it from the master branch. |
Collaborator
Author
|
Ah! It's not the GoReleaser build. It's Reproducible case rm -rf commands/types/dnscontrol.d.tsgo install |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2692
Introduction
The first iteration of GoReleaser refactor where the TypeScript file (
types-dnscontrol.d.ts) no longer needs to be generated manually, neither hardcoded is included in the source code. 🚀How have these activities been tested?
Set up local setup
Install GoReleaser
https://goreleaser.com/install/#homebrew
buildfrom the local machine.grep "^//" types-dnscontrol.d.tscc: @j-f1 for visibility of the TypeScript generation.