Skip to content

ROUTE53: add R53_EVALUATE_TARGET_HEALTH to documentation summary#2659

Merged
tlimoncelli merged 1 commit intoStackExchange:masterfrom
jonathanbouvier:doc_summary
Nov 29, 2023
Merged

ROUTE53: add R53_EVALUATE_TARGET_HEALTH to documentation summary#2659
tlimoncelli merged 1 commit intoStackExchange:masterfrom
jonathanbouvier:doc_summary

Conversation

@jonathanbouvier
Copy link
Copy Markdown
Contributor

This new record modifier wasn't showing up in the documentation. Is there anywhere else that needs to be updated to get this working?

@tlimoncelli
Copy link
Copy Markdown
Contributor

That's odd! The table of contents (navigation) is manually generated, and this PR should fix that.

However I don't see the page that the TOC will link to. It looks like the rebuild process worked (https://github.com/StackExchange/dnscontrol/actions/runs/7035630609/job/19146466173). Let's see if merging this and re-pushing the pages forces it to work. Failing that, it could be an issue with build/generate/functionTypes.go.

Tom

@tlimoncelli tlimoncelli merged commit 74a9e5e into StackExchange:master Nov 29, 2023
@tlimoncelli
Copy link
Copy Markdown
Contributor

Interesting!

I think the problem is that the system that translates /documentation/functions/record into /language-reference/record-modifiers isn't smart enough to handle relative links.

CC @cafferata

@cafferata
Copy link
Copy Markdown
Collaborator

See GitHub pull request #2669 for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants