Skip to content

NSONE: 524 Origin Time-out not handled as error #2627

@norman-zon

Description

@norman-zon

Describe the bug
When getting a 524 Origin Time-out response from NS1, the provider handles it as a WARNING and dnscontrol exits successfully.

To Reproduce
I can't figure out how to reproduce a 524.

Here is a log of one occurence:

[INFO: Diff2 algorithm in use. Welcome to the future!]
******************** Domain: myzone.de
WARNING: Error creating domain: PUT https://api.nsone.net/v1/zones/myzone.de: 524 <html>
<head><title>524 Origin Time-out</title><script src="/cdn-cgi/apps/head/BGkBeDlUJpHx3swQRyf58HOAico.js"></script></head>
<body bgcolor="white">
<center><h1>524 Origin Time-out</h1></center>
<hr><center>cloudflare-nginx</center>
</body>
</html>

Expected behavior
A 524 Error should be handled as an error and lead to dnscontrol failing with a non-zero exit code

DNS Provider
NS1

Additional context
dnscontrol v4.4.1

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions