-
Notifications
You must be signed in to change notification settings - Fork 492
OVH: provider only supports EU API endpoint #2625
Description
Is your feature request related to a problem? Please describe.
I use OVH Canada, which has a different endpoint than OVH in the EU (see here). Registering an application with OVH as described here must happen in the region of your OVH account, so as a Canadian client I have to register my application at https://ca.api.ovh.com/createApp rather than https://eu.api.ovh.com/createApp.
However, the OVH provider hardcodes the EU API endpoint, which means that applications registered by Canadian or US users can't be used:
dnscontrol/providers/ovh/ovhProvider.go
Line 37 in b8096b7
| c, err := ovh.NewClient(ovh.OvhEU, appKey, appSecretKey, consumerKey) |
Describe the solution you'd like
Ideally the provider could be configured to use the CA or US endpoints instead. This would be a non-breaking change as the default could still be the EU endpoint.
Describe alternatives you've considered
Canadian and US providers could be created based on the current one, but this seems like a lot of duplication.
Additional context
Add any other context or screenshots about the feature request here.