Skip to content

GCLOUD: Google will return an error if too many changes are specified in a single request  #2480

@asn-iac

Description

@asn-iac

Describe the bug
This is a known issue, but I couldn't find an existing GH issue:

// FIXME(tlim): Google will return an error if too many changes are
// specified in a single request. We should split up very large
// batches. This can be reliably reproduced with the 1201
// integration test. The error you get is:
// googleapi: Error 403: The change would exceed quota for additions per change., quotaExceeded

To Reproduce
Enable provider in 1201 test or 'dnscontrol push' any change with >1000 additions/deletions per zone

Expected behavior
Per TODO, changes should be batched

DNS Provider
-GCLOUD

Additional context
I have a PR that implements batching logic we've been using in an internal fork of dnscontrol. It's been used in configs with 2500+ GCLOUD domains and with thousands of records per zone. With the proposed changes, the provider is able to pass the 1201 integration test

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions