Build tools: centralize code-gen indent handling in a CodeWriter#3121
Merged
mgravell merged 1 commit intoJul 10, 2026
Merged
Conversation
…ckExchange#3033) Replaces the per-method 'int indent + local NewLine()' pattern in AsciiHashGenerator with a small builder-style CodeWriter wrapping the existing StringBuilder, per the second sketch in StackExchange#3033. Generated output is byte-for-byte identical.
Collaborator
|
Seems fine.. similar to some related code in my other libs... I can't think of a reason not to... |
mgravell
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #3033 using the second sketch from the issue: a small builder-style
CodeWriterwrapping the existingStringBuilder, replacing the per-methodint indent+ localNewLine()pattern inAsciiHashGenerator(4 occurrences).On the
IndentedTextWriteroption: its indent-on-next-write semantics would subtly change emitted whitespace. Since there was no functional win to justify that, I kept theStringBuildercore so the change is provably inert. (The preamble inGenerateintentionally still writes to the rawStringBuilderto keep the diff minimal.)Verification: captured generated output (
EmitCompilerGeneratedFiles) before and after —AsciiHash.generated.cs(1,835 lines) is byte-for-byte identical; full solution builds with zero warnings; RESPite.Tests pass (1717/1717).Closes #3033