Stabilize CI, especially on Windows#3109
Merged
Merged
Conversation
mgravell
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re
OBJECT IDLE- TIL: the Redis server suspends LRU updates for the duration ofhasActiveChildProcess()for saves, including replication; this means thatTOUCHetc is actually non-deterministic, since replication could happen at any time. This seems to have been causing CI instability, in particular on Windows (where the server is hosted inside WSL, compounding things).As a workaround, we move the
OBJECT IDLETIMEtests to use the :6381 endpoint, because that one doesn't have replication or persistence enabled.Additionally, we explicitly disable this test (and a few others, most notably
SENTINEL) on Windows; the WSL layer makes these tests super unreliable on the Windows CI.