Skip to content

Conversation

@tvdias
Copy link
Contributor

@tvdias tvdias commented Jul 14, 2023

Fixes #2467

@tvdias tvdias marked this pull request as draft July 14, 2023 14:00
@mgravell
Copy link
Collaborator

Suggest also:

  • release notes update
  • test if possible (if server version is blockage, fine)

@tvdias
Copy link
Contributor Author

tvdias commented Jul 17, 2023

  • release notes update

Fixed on 287bacd

  • test if possible (if server version is blockage, fine)

Fixed on f0f0a1d

@tvdias tvdias marked this pull request as ready for review July 18, 2023 13:52
@tvdias tvdias requested a review from mgravell July 18, 2023 13:52
@tvdias
Copy link
Contributor Author

tvdias commented Jul 18, 2023

@mgravell I'm getting this same error from 0faf311

image

@tvdias
Copy link
Contributor Author

tvdias commented Jul 21, 2023

@mgravell this is now ready. the last test that was added (on #2508) looks to be flaky and I had to retry the pipeline a couple of times until it works. also noticed it on the PR itself, that only worked on the 2nd pipeline run, when release notes were updated.

@tvdias
Copy link
Contributor Author

tvdias commented Aug 3, 2023

Hey @mgravell , I think this is ready to go. I'd squash it on merge because I had to create some dummy commits to trigger the build - idk if I could manually do it.

@tvdias
Copy link
Contributor Author

tvdias commented Aug 7, 2023

Hello @mgravell , can you please take a new look on this PR?

And please use the squash it on merge option, as I had created some dummy commits to trigger the builds (idk if I could manually do it).

Copy link
Collaborator

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current is looking great - thank you!

@NickCraver NickCraver merged commit 4cf2013 into StackExchange:main Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for entries-read and lag properties of XINFO GROUPS result in Redis 7

3 participants