Skip to content

Support multi-value pub/sub (and add client id tracking) #2508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mgravell merged 2 commits into from
Jul 12, 2023
Merged

Support multi-value pub/sub (and add client id tracking) #2508

mgravell merged 2 commits into from
Jul 12, 2023

Conversation

@mgravell
Copy link
Collaborator

@mgravell mgravell commented Jul 12, 2023 •
edited
Loading

This PR encorporates df805be - I did a stoopid and failed to branch

This change fixes #2507:

  • pub/sub messages with non-single bulk values should be usable; to avoid breaking the API, we unroll such messages into N discreet messages to the specified channel
  • adds connection-id tracking (used for test, but we want this later anyway - we've been meaning to add this for a while)

@mgravell mgravell requested a review from NickCraver July 12, 2023 13:55
NickCraver
NickCraver approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mgravell mgravell merged commit 8ce9e4d into main Jul 12, 2023
@mgravell mgravell deleted the fix2507 branch July 12, 2023 14:00
@mgravell mgravell changed the title release notes Support multi-value pub/sub (and add client id tracking) Jul 12, 2023
@tvdias tvdias mentioned this pull request Jul 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickCraver NickCraver NickCraver approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can't consume bulk keys from Invalidate channel

3 participants

@mgravell @NickCraver