DefaultOptionsProvider: allow overriding LibName #2453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a wrapper package is generally in use in a deployment, it may want to override what we set as the library name in `CLIENT SETINFO lib-name <name>`. This allows doing so via the `DefaultOptionsProvider` (intentionally not on `ConfigurationOptions` directly as version isn't either). Note that this does NOT upgrade the test suite to 7.2.0 RC1. I did test and this works, but there are other breaks we need to evaluate - I'll open another PR separately to demonstrate.
philon-msft
approved these changes
May 2, 2023
| /// Gets the library name to use for CLIENT SETINFO lib-name calls to Redis during handshake. | ||
| /// Defaults to "SE.Redis". | ||
| /// </summary> | ||
| public virtual string LibraryName => "SE.Redis"; |
Collaborator
There was a problem hiding this comment.
Should use RedisLiterals.SE_Redis?
Collaborator
Author
There was a problem hiding this comment.
Nah...but we should clean that up, done!
| msg.SetInternalCall(); | ||
| await WriteDirectOrQueueFireAndForgetAsync(connection, msg, ResultProcessor.DemandOK).ForAwait(); | ||
| var libName = Multiplexer.RawConfig.Defaults.LibraryName; | ||
| if (!string.IsNullOrEmpty(libName)) |
Collaborator
Author
There was a problem hiding this comment.
YES, meant this - good catch!
mgravell
reviewed
May 3, 2023
| { | ||
| // note that this is a relatively new feature, but usually we won't know the | ||
| // server version, so we will use this speculatively and hope for the best | ||
| log?.WriteLine($"{Format.ToString(this)}: Setting client lib/ver"); |
Collaborator
There was a problem hiding this comment.
a bit late now, but: maybe this should be inside the null/empty check
Collaborator
Author
There was a problem hiding this comment.
Agree it's weird, but there are 2 distinct checks and 1 log message atm - we could log each, change the method, or something else - thoughts? Happy to tidy up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a wrapper package is generally in use in a deployment, it may want to override what we set as the library name in
CLIENT SETINFO lib-name <name>. This allows doing so via theDefaultOptionsProvider(intentionally not onConfigurationOptionsdirectly as version isn't either).Note that this does NOT upgrade the test suite to 7.2.0 RC1. I did test and this works, but there are other breaks we need to evaluate - I'll open another PR separately to demonstrate.