Add support for CLIENT SETINFO #2414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t on any released servers
philon-msft
approved these changes
Mar 28, 2023
NickCraver
requested changes
Mar 28, 2023
Collaborator
NickCraver
left a comment
NickCraver
left a comment
There was a problem hiding this comment.
Few tweaks then good to go!
NickCraver
changed the title
philon-msft
reviewed
Mar 28, 2023
NickCraver
approved these changes
Mar 28, 2023
Collaborator
NickCraver
left a comment
NickCraver
left a comment
There was a problem hiding this comment.
👍 Current looks good!
Collaborator
|
@philon-msft could you please double check me on latest? |
Collaborator
Looks great to me @NickCraver |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes:
note we can't validate this yet as not on any released servers
most contentious point: what lib-name to use - I've gone with
SE.Redis, but: happy to useStackExchange.Redisif people prefer; I'm not aiming to make the name configurablecross-reference: redis/redis#11758