ServerSnapshot: Improve API and allow filtering with custom struct enumerator #2337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickCraver
approved these changes
Jan 4, 2023
Collaborator
NickCraver
left a comment
NickCraver
left a comment
There was a problem hiding this comment.
This looks awesome - no notes, much cleaner and dig the implementation. Good call going this route!
NickCraver
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so we aren't limited just to
ReadOnlySpan<ServerEndpoint>, and don't need the allocateyToArray()implemented as custom iterator which allows
asyncand LINQ to work directly' existing code still uses span for efficiency, with the new API used in limited scenarios onlyintent here:
Where(CommandFlags)basis for upcoming broadcast work