Implement IAsyncDisposable from IConnectionMultiplexer #2161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hey @kimsey0 - we should add release notes and move the API to the Shipped set in-order but then good to go. Happy to take care of that to get this in if you want :) |
kimsey0
force-pushed
the
iasyncdisposable
branch
from
7a829f0 to
5b086e6
Compare
Contributor
Author
|
@NickCraver: I moved the API change to shipped and added a new line under Unreleased in the release notes document. I haven't used |
NickCraver
requested changes
Jul 25, 2022
Collaborator
NickCraver
left a comment
NickCraver
left a comment
There was a problem hiding this comment.
This is looking good! 1 issue introduced with a null ref in dispose though - need to shuffle a bit on how that's handled (comments inline).
NickCraver
requested changes
Jul 25, 2022
Co-authored-by: Nick Craver <[email protected]>
NickCraver
approved these changes
Jul 26, 2022
Collaborator
NickCraver
left a comment
NickCraver
left a comment
There was a problem hiding this comment.
Looking good, thank you!
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2160.
We may want to implement
IAsyncDisposablein more publicIDisposableclasses which can dispose their resources asynchronously.