Support COMMAND [...] #2143
Merged
Support COMMAND [...] #2143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I just see some trailing spaces on tests to tidy - wanted to comment early this is looking great! |
Contributor
Author
|
@NickCraver |
|
Part of #2055 |
NickCraver
requested changes
May 21, 2022
Collaborator
NickCraver
left a comment
NickCraver
left a comment
There was a problem hiding this comment.
Trying to catch up a bit - thanks for this! The first set looks good, but I think the second set is split up a bit too much - normally in our API patterns you'd expect 1 command with some arguments for CommandGetkeys, so let's collapse that down to the main CommandGetkeys() method with string params for the 3 possible filters :)
NickCraver
reviewed
May 24, 2022
NickCraver
approved these changes
May 24, 2022
Collaborator
NickCraver
left a comment
NickCraver
left a comment
There was a problem hiding this comment.
Current is looking great - thanks for the work here!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to commands:
COMMAND COUNT - https://redis.io/commands/command-count/
COMMAND GETKEYS - https://redis.io/commands/command-getkeys/
COMMAND LIST - https://redis.io/commands/command-list/