-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Support GT, LT and CH in ZADD command #2136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support GT, LT and CH in ZADD command #2136
Conversation
|
I think we should do all the things at once here given it's the same overloads, yep - @mgravell and I are unsure about the |
|
Great! Glad you're back :) |
|
Hmm yeah okay let's ignore for now - plan is if someone needs the combo of these args and INCR, then we can add it to |
|
@Avital-Fine talking about this in call - can we please try renaming the /cc @mgravell |
Maybe we can add SortedSetAddFlags and then we can include there CH flag? WDYT? |
|
Also it will be super easy to support INCR |
|
Hey @NickCraver! |
|
@Avital-Fine ACK! Sorry I've been swamped and not on this hardly at all - @mgravell is going to give compat eyes here :) |
SortedSetAdd currently not supporting GT and LT features.
Also, CH is not supported. @NickCraver Should I add it here in this PR too?