Fix race condition in Sentinel connection multiplexer #2133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickCraver
approved these changes
May 10, 2022
Collaborator
NickCraver
left a comment
NickCraver
left a comment
There was a problem hiding this comment.
Looking good - thanks for the fix here!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Sentinel Connection Multiplexer, since
OnManagedConnectionRestoredcan be executed on a different thread, it's possible for it to dispose the timer just beforeOnManagedConnectionFailedcalls.Change()on the timer, which leads to anObjectDisposedExceptionbeing thrown inOnManagedConnectionFailed. Since the connection was restored, it seems safe to suppress these exceptions, instead of requiring locking around the reference toconnection.sentinelPrimaryReconnectTimer.