#2008 Follow-ups #2009
Merged
#2008 Follow-ups #2009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few tweaks to the changes #2008 for disposing and normalization.
| public void Dispose() | ||
| { | ||
| isDisposed = true; | ||
| _backlogAutoReset?.Dispose(); |
Contributor
There was a problem hiding this comment.
Why ?. - this is readonly, don't see how it could end up null.
Collaborator
Author
There was a problem hiding this comment.
I always like to guard in case this implementation changes later - agreed it's not needed atm.
Contributor
There was a problem hiding this comment.
I suppose in the absence of nullable reference types that's reasonable.
Collaborator
Author
There was a problem hiding this comment.
Aye - this project isn't too large...should take that on one of these days.
philon-msft
approved these changes
Feb 24, 2022
Collaborator
philon-msft
left a comment
philon-msft
left a comment
There was a problem hiding this comment.
These are the other awaits I saw in ConnectionMultiplexer.cs without ForAwait():
await srv.PingAsync(flags); // if it isn't happy, we're not happy
await node.WriteDirectAsync(msg, ResultProcessor.DemandOK);
await srv.ReplicaOfAsync(null, flags);
await server.WriteDirectAsync(msg, ResultProcessor.DemandOK);
await node.WriteDirectAsync(msg, ResultProcessor.Int64);
await BroadcastAsync(nodes);
await node.WriteDirectAsync(msg, ResultProcessor.DemandOK);
await BroadcastAsync(nodes);
if (!await ReconfigureAsync(first: false, reconfigureAll: true, log, srv.EndPoint, "make master"))
return await ReconfigureAsync(first: false, reconfigureAll: true, logProxy, null, "configure").ObserveErrors();
Collaborator
Author
|
@philon-msft ACK - for completeness let's handle those separately but agreed no reason not to tidy as long as we're supporting full framework. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few tweaks to the changes #2008 for disposing and normalization.