Implement GET option of SET command #2003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickCraver
requested changes
Feb 19, 2022
Collaborator
NickCraver
left a comment
NickCraver
left a comment
There was a problem hiding this comment.
I see some quick doc fixes but this is looking excellent, thank you! I need to poke a bit more with fresh eyes but I think we're good - 👍 from me on current naming.
NickCraver
approved these changes
Feb 22, 2022
Collaborator
NickCraver
left a comment
NickCraver
left a comment
There was a problem hiding this comment.
I've touched this so should get extra eyes /cc @mgravell
Collaborator
|
@martinekvili thanks for this!! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redis 6.2.0 has deprecated the GETSET command and in turn added the
GEToption to the SET command.Note: I am not 100% happy with the
StringSetAndGetmethod name. However, I am quite torn, as it would be nice to call itStringGetSetto better show the intent and the deprecation of the old method. On the other hand, I quite like how this driver follows the names of the underlying Redis commands quite closely. The current name tries to follow that convention.