Skip to content

Initialize ScriptEvalMessage with the correct command #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NickCraver merged 2 commits into from
Dec 31, 2021
Merged

Initialize ScriptEvalMessage with the correct command #1930

NickCraver merged 2 commits into from
Dec 31, 2021

Conversation

@martinpotter
Copy link
Contributor

@martinpotter martinpotter commented Dec 14, 2021

Currently the constructor for ScriptEvalMessage that takes a SHA1 hash, and sends the EVALSHA command, initializes the base Message class's command to RedisCommand.EVAL instead of RedisCommand.EVALSHA.

@mgravell
Copy link
Collaborator

mgravell commented Dec 14, 2021

wow; looks like we missed a critical test here - presumably this never worked! good eyes

@mgravell
Copy link
Collaborator

mgravell commented Dec 14, 2021

could you please also add a line to releasenotes.md (you'll see the pattern); if you're feeling especially generous, it would also be great to add a test here to show it working, but: if not, I can go back and add some here

@martinpotter
Copy link
Contributor Author

martinpotter commented Dec 14, 2021

wow; looks like we missed a critical test here

As far as I can tell, this really is only an issue for things like profiling (OpenTelemetry, NR, etc) that log the Command since ScriptEvalMessage overrides WriteImpl and [correctly writes] (

StackExchange.Redis/src/StackExchange.Redis/RedisDatabase.cs

Lines 3863 to 3867 in ddf9341

if (hexHash != null)
{
physical.WriteHeader(RedisCommand.EVALSHA, 2 + keys.Length + values.Length);
physical.WriteSha1AsHex(hexHash);
}
) RedisCommand.EVALSHA to the connection.

@mgravell
Copy link
Collaborator

mgravell commented Dec 14, 2021

@martinpotter that probably makes it even more useful to have a test, honestly :)

@NickCraver
Copy link
Collaborator

NickCraver commented Dec 31, 2021

Missed the force push here, thanks for the test update! Kicking off builds :)

NickCraver
NickCraver approved these changes Dec 31, 2021
View reviewed changes
Copy link
Collaborator

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks for the catch and the fix!

@NickCraver NickCraver merged commit 1384bd8 into StackExchange:main Dec 31, 2021
NickCraver added a commit that referenced this pull request Dec 31, 2021
@NickCraver
Add #1930 to release notes
9adac77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickCraver NickCraver NickCraver approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@martinpotter @mgravell @NickCraver