-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Adding doc for ServerMaintenanceEvent #1894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mgravell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth adding a very brief one sentence version of what to do if you're a redis vendor and want to integrate support (which probably means: open an issue, so we can discuss the details)
NickCraver
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got time this morning to walk through with fresh eyes - pointed out the things that are unclear/confusing to me as a user but it's possible I'm wrong about all of them. Happy to chat async or hop on but this looks very close 👍
Co-authored-by: Nick Craver <[email protected]>
NickCraver
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normalized a few bits but looking good, thanks! The only thing I'm confused about here is an extra file :)
CodeMaid.config
Outdated
| </setting> | ||
| </SteveCadwallader.CodeMaid.Properties.Settings> | ||
| </userSettings> | ||
| </configuration> No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I...dunno what this file is :)
NickCraver
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!!
Sorry for the extra config file there 😂 glad you caught it! Thanks for all the help Nick! |
Documentation for the feature introduced here: #1876