Skip to content

Conversation

@amsoedal
Copy link
Contributor

Documentation for the feature introduced here: #1876

Copy link
Collaborator

@mgravell mgravell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth adding a very brief one sentence version of what to do if you're a redis vendor and want to integrate support (which probably means: open an issue, so we can discuss the details)

@philon-msft
Copy link
Collaborator

philon-msft commented Oct 26, 2021

Let's add a link to this new doc in index.md


In reply to: 952175075


In reply to: 952175075

Copy link
Collaborator

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got time this morning to walk through with fresh eyes - pointed out the things that are unclear/confusing to me as a user but it's possible I'm wrong about all of them. Happy to chat async or hop on but this looks very close 👍

@amsoedal amsoedal requested a review from NickCraver November 3, 2021 17:33
Copy link
Collaborator

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normalized a few bits but looking good, thanks! The only thing I'm confused about here is an extra file :)

CodeMaid.config Outdated
</setting>
</SteveCadwallader.CodeMaid.Properties.Settings>
</userSettings>
</configuration> No newline at end of file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I...dunno what this file is :)

Copy link
Collaborator

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!!

@NickCraver NickCraver dismissed mgravell’s stale review November 4, 2021 01:29

Ch-ch-ch-ch-chaaaaaaaanges

@NickCraver NickCraver merged commit ccb5f42 into main Nov 4, 2021
@NickCraver NickCraver deleted the amsoedal/maintenance_event_doc branch November 4, 2021 01:38
@amsoedal
Copy link
Contributor Author

amsoedal commented Nov 4, 2021

Thanks for this!!

Sorry for the extra config file there 😂 glad you caught it! Thanks for all the help Nick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants