Tweaks for #1876 #1877
Merged
Tweaks for #1876 #1877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amsoedal
reviewed
Oct 6, 2021
amsoedal
reviewed
Oct 6, 2021
| case var _ when key.SequenceEqual(nameof(SSLPort).AsSpan()) && Int32.TryParse(value.ToString(), out var port): | ||
| SSLPort = port; | ||
| case var _ when key.SequenceEqual("SSLPort".AsSpan()) && int.TryParse(value.ToString(), NumberStyles.Integer, NumberFormatInfo.InvariantInfo, out var port): | ||
| SslPort = port; |
Contributor
There was a problem hiding this comment.
suggest: Do we want to use Format.TryParseInt32() here instead?
amsoedal
reviewed
Oct 6, 2021
|
|
||
| /// <summary> | ||
| /// IPAddress of the node event is intended for. | ||
| /// IPAddress of the node event is intended for |
Contributor
There was a problem hiding this comment.
nit: delete this old line?
philon-msft
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing a set of suggestions here following our call - cc @amsoedal! I've just merged up latest, will do a test run here but wanted to get changes to make it a bit more extensible for other clouds and easier to consume in front of your eyes. Philo added some color around the purposes for the public events (makes sense!), so was trying to make using them a bit cleaner on the client side, e.g.:
The extensibility model would be other cloud providers adding a PR here, which would consist in total of their handler (if different) and adding to the base
ServerMaintenanceEvent(not meant to be externally extensible at the moment).Can you please provide thoughts?