Add support for GETDEL command #1840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgravell
previously requested changes
Aug 20, 2021
Collaborator
mgravell
left a comment
mgravell
left a comment
There was a problem hiding this comment.
Looks fine, ta. Please could you add to the release notes md file, in the unreleased section, thanks. An integration test would be ideal, but I don't know if our CI redis servers offer this feature - would have to check.
Contributor
Author
|
Thanks @mgravell, the command order had been updated to be alphabetical and the release notes had been added. |
Contributor
Author
|
Hi @mgravell , the integration test had been added and I had test it locally on my side, any more changes needed? |
NickCraver
approved these changes
Oct 5, 2021
Collaborator
NickCraver
left a comment
NickCraver
left a comment
There was a problem hiding this comment.
Thanks for the additions and the tweaks here - looking great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1729