prevent GetOutstandingCount from throwing #1792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickCraver
approved these changes
Jun 30, 2021
Collaborator
NickCraver
left a comment
NickCraver
left a comment
There was a problem hiding this comment.
👍 1 release notes tweak to be consistent but LGTM
Co-authored-by: Nick Craver <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few stack-traces have shown
GetOutstandingCountparticipating in faults due to broken sockets etc; however, we useGetOutstandingCountfrom within those handlers, so: allowing it to blow up could be masking the original/underlying exception; fix that, by makingGetOutstandingCountbest-efforts only